Re: [PATCH] cpufreq: imx6q: Only disabling 792MHz OPP for i.MX6ULL types below 792MHz

[Fabio Estevam]

Hi Christoph,

Thanks for your patch.

On 07/11/2023 13:31, Christoph Niedermaier wrote:
> For a 900MHz i.MX6ULL CPU the 792MHz OPP is disabled. There is no
> convincing reason to disable this OPP. If a CPU can run at 900MHz,
> it should also be able to cope with 792MHz. Looking at the voltage
> level of 792MHz in [1] (page 24, table 10. "Operating Ranges") the
> current defined OPP is above the minimum. So the voltage level
> shouldn't be a problem. Although in [2] (page 24, table 10.
> "Operating Ranges") 792MHz isn't mentioned there isn't note that
> 792MHz OPP isn't allowed. Change it to only disable 792MHz OPP for

I find this part:

"792MHz isn't mentioned there isn't note that 792MHz OPP isn't allowed."

a bit confusing.

Maybe:

"However in [2] (page 24, table 10. "Operating Ranges"), it is not 
mentioned that 792MHz OPP isn't allowed."


> [1] https://www.nxp.com/docs/en/data-sheet/IMX6ULLIEC.pdf
> [2] https://www.nxp.com/docs/en/data-sheet/IMX6ULLCEC.pdf
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Marek Vasut <marex@xxxxxxx>

I think it is worth adding a Fixes tag so that this fix could be 
backported
to stable kernels.

Reviewed-by: Fabio Estevam <festevam@xxxxxxx>

Thanks