Re: [PATCH v2 2/4] KVM: s390: vsie: Fix length of facility list shadowed

From: Claudio Imbrenda
Date: Tue Nov 07 2023 - 12:11:52 EST


On Tue, 7 Nov 2023 13:31:16 +0100
Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx> wrote:

[...]

> -obj-y += smp.o text_amode31.o stacktrace.o abs_lowcore.o
> +obj-y += smp.o text_amode31.o stacktrace.o abs_lowcore.o facility.o
>
> extra-y += vmlinux.lds
>
> diff --git a/arch/s390/kernel/facility.c b/arch/s390/kernel/facility.c
> new file mode 100644
> index 000000000000..5e80a4f65363
> --- /dev/null
> +++ b/arch/s390/kernel/facility.c

I wonder if this is the right place for this?

This function seems to be used only for vsie, maybe you can just move
it to vsie.c? or do you think it will be used elsewhere too?

[...]