Re: [PATCH v6 2/2] rtc: max31335: add driver support

From: kernel test robot
Date: Tue Nov 07 2023 - 07:34:35 EST


Hi Antoniu,

kernel test robot noticed the following build errors:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linus/master v6.6 next-20231107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Antoniu-Miclaus/rtc-max31335-add-driver-support/20231104-202238
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20231104112752.3217-2-antoniu.miclaus%40analog.com
patch subject: [PATCH v6 2/2] rtc: max31335: add driver support
config: x86_64-randconfig-121-20231107 (https://download.01.org/0day-ci/archive/20231107/202311071920.P1lDlqTA-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231107/202311071920.P1lDlqTA-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311071920.P1lDlqTA-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

ld: vmlinux.o: in function `max31335_clkout_register':
>> drivers/rtc/rtc-max31335.c:595: undefined reference to `devm_clk_hw_register'
>> ld: drivers/rtc/rtc-max31335.c:599: undefined reference to `of_clk_hw_simple_get'
>> ld: drivers/rtc/rtc-max31335.c:599: undefined reference to `devm_of_clk_add_hw_provider'


vim +595 drivers/rtc/rtc-max31335.c

583
584 static int max31335_clkout_register(struct device *dev)
585 {
586 struct max31335_data *max31335 = dev_get_drvdata(dev);
587 int ret;
588
589 if (!device_property_present(dev, "#clock-cells"))
590 return regmap_clear_bits(max31335->regmap, MAX31335_RTC_CONFIG2,
591 MAX31335_RTC_CONFIG2_ENCLKO);
592
593 max31335->clkout.init = &max31335_clk_init;
594
> 595 ret = devm_clk_hw_register(dev, &max31335->clkout);
596 if (ret)
597 return dev_err_probe(dev, ret, "cannot register clock\n");
598
> 599 ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get,
600 &max31335->clkout);
601 if (ret)
602 return dev_err_probe(dev, ret, "cannot add hw provider\n");
603
604 max31335->clkout.clk = devm_clk_get_enabled(dev, NULL);
605 if (IS_ERR(max31335->clkout.clk))
606 return dev_err_probe(dev, PTR_ERR(max31335->clkout.clk),
607 "cannot enable clkout\n");
608
609 return 0;
610 }
611

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki