Re: [PATCH 2/4] sched/eevdf: Sort the rbtree by virtual deadline
From: Peter Zijlstra
Date: Tue Nov 07 2023 - 06:04:10 EST
On Tue, Nov 07, 2023 at 05:05:08PM +0800, Abel Wu wrote:
> Sort the task timeline by virtual deadline and keep the min_vruntime
> in the augmented tree, so we can avoid doubling the worst case cost
> and make full use of the cached leftmost node to enable O(1) fastpath
> picking in next patch.
Another very good patch, just a note:
> This patch also cleans up the unused max_vruntime() and adjusts pos
> for some functions.
There's this thing about saying 'this patch' in Changelogs, per
definition the Changelog is about 'this patch' so saying it is a bit
redundant.
It even gets mentioned in the Documentation on submitting patches
somewhere.
But what I care about more is this patch doing extra unrelated things,
this should be split out.