Re: [PATCH v1] USB: dwc3: only call usb_phy_set_suspend in suspend/resume

[Stefan Eichenberger]

> From: Johan Hovold <johan@xxxxxxxxxx>
> >
> > We have an external hub that we want to turn off when the system goes
> > into suspend. For the i.MX8MM we use the phy-generic driver to achieve
> > this. When I saw that the dwc3 driver would support the phy-generic via
> > usb-phy, I thought we could use the same approach for the i.MX8MP and,
> > in the future, the AM62. Maybe I misunderstood, would the right solution
> > be to add a suspend function to the fsl,imx8mp-usb-phy driver and use
> > vbus instead? But what would we do for the AM62, as it doesn't have a
> > phy driver if I'm not mistaken.
>
> That's not how the phy driver is supposed be used, and for on-board hubs
> we now have:
>
>         drivers/usb/misc/onboard_usb_hub.c
>
> Have you tried using that one instead?

Thanks for the tip. I have now tested it and it seems to work for our
use case. I will see if I can use it for the other devices as well.

Best regards,
Stefan