Re: [PATCH] ARM: davinci: also select PINCTRL

From: Bartosz Golaszewski
Date: Tue Nov 07 2023 - 04:11:31 EST


On Tue, Nov 7, 2023 at 1:36 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> kconfig warns when PINCTRL_SINGLE is selected but PINCTRL is not
> set, so also set PINCTRL for ARCH_DAVINCI. This prevents a
> kconfig/build warning:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
> Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
> Selected by [y]:
> - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: lore.kernel.org/r/202311070548.0f6XfBrh-lkp@xxxxxxxxx
> Cc: Bartosz Golaszewski <brgl@xxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: patches@xxxxxxxxxxxxxxx
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> ---
> KernelVersion: 6.6
>
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -10,6 +10,7 @@ menuconfig ARCH_DAVINCI
> select PM_GENERIC_DOMAINS_OF if PM && OF
> select REGMAP_MMIO
> select RESET_CONTROLLER
> + select PINCTRL
> select PINCTRL_SINGLE
>
> if ARCH_DAVINCI

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>