Re: [PATCH 14/21] binder: do not add pages to LRU in release path
From: Alice Ryhl
Date: Tue Nov 07 2023 - 04:09:16 EST
Carlos Llamas <cmllamas@xxxxxxxxxx> writes:
> In binder_alloc_deferred_release() pages are added to the LRU list via
> binder_free_buf_locked(). However, this is pointless because these pages
> are kfree'd immediately afterwards. Add an option to skip the LRU list.
They aren't freed with kfree, buf with __free_page.
> Signed-off-by: Carlos Llamas <cmllamas@xxxxxxxxxx>
The change itself looks correct, so I'll give my tag for this:
Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
But I'm wondering whether process cleanup really is so performance
intensive to justify the added complexity of this?
Alice