Re: [PATCH net-next V8 2/2] ptp: fix corrupted list in ptp_open

From: Richard Cochran
Date: Tue Nov 07 2023 - 01:13:33 EST


On Mon, Nov 06, 2023 at 10:31:28PM +0800, Edward Adam Davis wrote:
> There is no lock protection when writing ptp->tsevqs in ptp_open() and
> ptp_release(), which can cause data corruption, use spin lock to avoid this
> issue.
>
> Moreover, ptp_release() should not be used to release the queue in ptp_read(),
> and it should be deleted altogether.
>
> Reported-and-tested-by: syzbot+df3f3ef31f60781fa911@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers")
> Signed-off-by: Edward Adam Davis <eadavis@xxxxxx>

(This should go to net and not net-next.)

Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>