Re: [PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes

From: Doug Anderson
Date: Mon Nov 06 2023 - 16:12:52 EST


Hi,

On Mon, Nov 6, 2023 at 1:03 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
>
> @@ -622,7 +627,7 @@ static int panel_edp_get_modes(struct drm_panel *panel,
> * and no modes (the generic edp-panel case) because it will clobber
> * the display_info that was already set by drm_add_edid_modes().
> */
> - if (p->desc->num_timings || p->desc->num_modes)
> + if (has_hard_coded_modes)

nit: the comment above this line is a bit confusing now and probably
needs to be updated or removed.