RE: [PATCH v2 12/13] scsi: fnic: Add support for multiqueue (MQ) in fnic driver

From: Karan Tilak Kumar (kartilak)
Date: Mon Nov 06 2023 - 15:25:45 EST


On Thursday, November 2, 2023 1:12 AM, Hannes Reinecke <hare@xxxxxxx> wrote:
>
> On 10/27/23 20:03, Karan Tilak Kumar wrote:
> >
> That is odd.
> If you pass in 'mqtag' you can derive the hardware queue from it, so you don't need to pass it in separately.
> Alternative it would make sense to pass in the 'tag' value instead of 'mqtag', as this would simplify the code (seeint that you don't have to call blk_mq_unique_tag_to_tag() all over the place).
>
> Cheers,
> Hannes
>
>

The former approach sounds better.
I'll adopt it in v3.

Regards,
Karan