Re: [PATCH] regmap: add regmap_update_bits variant to autoshift mask

From: Mark Brown
Date: Mon Nov 06 2023 - 11:54:44 EST


On Mon, Nov 06, 2023 at 05:34:06PM +0100, Brandon Cheo Fusi wrote:

> +static inline int regmap_update_bits_autoshift_val(struct regmap *map, unsigned int reg,
> + unsigned int mask, unsigned int val)
> +{

Really not a fan of the name here, and in any case if the shifting of
the value is an issue wouldn't this be a good case for using a field?

Please also add kunit testcases for new APIs.

Attachment: signature.asc
Description: PGP signature