Re: [PATCH v2 2/3] dt-bindings: media: i2c: add galaxycore,gc2145 dt-bindings

[Alain Volmat]

Hi Sakari,

On Wed, Nov 01, 2023 at 01:23:56PM +0000, Sakari Ailus wrote:
> Hi Alain,
> 
> On Wed, Oct 11, 2023 at 07:57:29PM +0200, Alain Volmat wrote:
> > Introduction of the Galaxy Core GC2145 XVGA CMOS camera sensor.
> > 
> > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> > ---
> >  .../bindings/media/i2c/galaxycore,gc2145.yaml | 104 ++++++++++++++++++
> >  1 file changed, 104 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > new file mode 100644
> > index 000000000000..94d194cf5452
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > @@ -0,0 +1,104 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/galaxycore,gc2145.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Galaxy Core 1/5'' UXGA CMOS Image Sensor
> > +
> > +maintainers:
> > +  - Alain Volmat <alain.volmat@xxxxxxxxxxx>
> > +
> > +description:
> > +  The Galaxy Core GC2145 is a high quality 2 Mega CMOS image sensor, for mobile
> > +  phone camera applications and digital camera products. GC2145 incorporates a
> > +  1616V x 1232H active pixel array, on-chip 10-bit ADC, and image signal
> > +  processor. It is programmable through an I2C interface. Image data is sent
> > +  either through a parallel interface or through MIPI CSI-2.
> > +
> > +allOf:
> > +  - $ref: ../video-interface-devices.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: galaxycore,gc2145
> > +
> > +  reg:
> > +    const: 0x3c
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  powerdown-gpios:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +  iovdd-supply:
> > +    description: Power Supply for I/O circuits (1.7 - 3V).
> > +
> > +  avdd-supply:
> > +    description: Power for analog circuit/sensor array (2.7 - 3V).
> > +
> > +  dvdd-supply:
> > +    description: Power for digital core (1.7 - 1.9V).
> > +
> > +  orientation: true
> > +
> > +  rotation: true
> > +
> > +  port:
> > +    $ref: /schemas/graph.yaml#/$defs/port-base
> > +
> > +    properties:
> > +      endpoint:
> > +        $ref: /schemas/media/video-interfaces.yaml#
> > +        unevaluatedProperties: false
> > +
> > +    required:
> > +      - endpoint
> 
> Could you add link-frequencies here, too?

This sensor is only used for the time being (as far as I know) on the
the stm32mp135f-dk board which can well handle the 3 link-frequencies.
(some other usages exist, however in parallel mode, which this driver
doesn't support yet).
I was hoping to only add the link-frequencies check when it becomes
necessary to use it on another board.
Do that make sense ?

Regards,
Alain