Re: [PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate

From: Rob Herring
Date: Mon Nov 06 2023 - 09:41:48 EST


On Wed, Nov 01, 2023 at 02:35:13PM +0800, Seven Lee wrote:
> Add input with DMIC slew rate controls
>
> Signed-off-by: Seven Lee <wtli@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> index 3e54abd4ca74..48c389276a15 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -89,6 +89,13 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 3072000
>
> + nuvoton,dmic-slew-rate:
> + description: The range 0 to 7 represents the speed of DMIC slew rate.
> + The lowest value 0 means the slowest rate and the highest value
> + 7 means the fastest rate.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0

Don't write constraints in prose:

maximum: 7

> +
> nuvoton,left-input-single-end:
> description: Enable left input with single-ended settings if set.
> For the headset mic application, the single-ended control is
> @@ -127,6 +134,7 @@ examples:
> nuvoton,jack-insert-debounce = <7>;
> nuvoton,jack-eject-debounce = <0>;
> nuvoton,dmic-clk-threshold = <3072000>;
> + nuvoton,dmic-slew-rate= <0>;
> #sound-dai-cells = <0>;
> };
> };
> --
> 2.25.1
>