Re: [PATCH 1/8] mfd: qcom-spmi-pmic: Add support for PM8937

[Caleb Connolly]

On 06/11/2023 12:08, Dang Huynh wrote:
> Add the subtype and compatible strings for PM8937.
> 
> The PM8937 is found in various SoCs, including MSM8917, MSM8937,
> MSM8940 and APQ variants.
> 
> Signed-off-by: Dang Huynh <danct12@xxxxxxxxxx>

Reviewed-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
> ---
>  drivers/mfd/qcom-spmi-pmic.c      | 1 +
>  include/soc/qcom/qcom-spmi-pmic.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
> index 4549fa9f7d4b..eab5bf6cff10 100644
> --- a/drivers/mfd/qcom-spmi-pmic.c
> +++ b/drivers/mfd/qcom-spmi-pmic.c
> @@ -53,6 +53,7 @@ static const struct of_device_id pmic_spmi_id_table[] = {
>  	{ .compatible = "qcom,pm8901", .data = N_USIDS(2) },
>  	{ .compatible = "qcom,pm8909", .data = N_USIDS(2) },
>  	{ .compatible = "qcom,pm8916", .data = N_USIDS(2) },
> +	{ .compatible = "qcom,pm8937", .data = N_USIDS(2) },
>  	{ .compatible = "qcom,pm8941", .data = N_USIDS(2) },
>  	{ .compatible = "qcom,pm8950", .data = N_USIDS(2) },
>  	{ .compatible = "qcom,pm8994", .data = N_USIDS(2) },
> diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
> index c47cc71a999e..17a0a8c3d656 100644
> --- a/include/soc/qcom/qcom-spmi-pmic.h
> +++ b/include/soc/qcom/qcom-spmi-pmic.h
> @@ -31,6 +31,7 @@
>  #define PM8998_SUBTYPE		0x14
>  #define PMI8998_SUBTYPE		0x15
>  #define PM8005_SUBTYPE		0x18
> +#define PM8937_SUBTYPE		0x19
>  #define PM660L_SUBTYPE		0x1a
>  #define PM660_SUBTYPE		0x1b
>  #define PM8150_SUBTYPE		0x1e
> 

-- 
// Caleb (they/them)