Re: [PATCH 7/8] arm64: dts: qcom: Add PM8937 PMIC

[Dmitry Baryshkov]

On Mon, 6 Nov 2023 at 14:11, Dang Huynh <danct12@xxxxxxxxxx> wrote:
>
> The PM8937 features integrated peripherals like ADC, GPIO controller,
> MPPs, PON keys and others.
>
> Add the device tree so that any boards with this PMIC can use it.
>
> Signed-off-by: Dang Huynh <danct12@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pm8937.dtsi | 202 +++++++++++++++++++++++++++++++++++
>  1 file changed, 202 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8937.dtsi b/arch/arm64/boot/dts/qcom/pm8937.dtsi
> new file mode 100644
> index 000000000000..6091d6938885
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8937.dtsi
> @@ -0,0 +1,202 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Dang Huynh <danct12@xxxxxxxxxx>
> + */
> +
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +/ {
> +       thermal-zones {
> +               pm8937-thermal {
> +                       polling-delay-passive = <0>;
> +                       polling-delay = <0>;
> +                       thermal-sensors = <&pm8937_temp>;
> +
> +                       trips {
> +                               pm8937_trip0: pm8937-trip0 {

I don't think you need labels here. Also you can drop PMIC name from
trip point node names.

> +                                       temperature = <105000>;
> +                                       hysteresis = <0>;
> +                                       type = "passive";
> +                               };
> +                               pm8937_trip1: pm8937-trip1 {
> +                                       temperature = <125000>;
> +                                       hysteresis = <0>;
> +                                       type = "passive";
> +                               };
> +                               pm8937_trip2: pm8937-trip2 {
> +                                       temperature = <145000>;
> +                                       hysteresis = <0>;
> +                                       type = "passive";

145°C is very hot for the passive trip point

Comparing this with other platforms, 125°C can be "hot" and 145°C is "critical".

Other than that:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> +                               };
> +                       };
> +               };
> +       };
> +};


-- 
With best wishes
Dmitry