Re: [PATCH net 0/4] vsock: fix server prevents clients from reconnecting

[Stefano Garzarella]

On Fri, Nov 03, 2023 at 06:55:47PM +0100, f.storniolo95@xxxxxxxxx wrote:
> From: Filippo Storniolo <f.storniolo95@xxxxxxxxx>
>
> This patch series introduce fix and tests for the following vsock bug:
> If the same remote peer, using the same port, tries to connect
> to a server on a listening port more than once, the server will
> reject the connection, causing a "connection reset by peer"
> error on the remote peer. This is due to the presence of a
> dangling socket from a previous connection in both the connected
> and bound socket lists.
> The inconsistency of the above lists only occurs when the remote
> peer disconnects and the server remains active.
> This bug does not occur when the server socket is closed.
>
> More details on the first patch changelog.
> The remaining patches are refactoring and test.

Thanks for the fix and the test!

I only left a small comment in patch 2 which I don't think justifies a
v2 by itself though. If for some other reason you have to send a v2,
then maybe I would fix it.

I reviewed the series and ran the tests. Everything seems to be fine.

Thanks,
Stefano