Re: [PATCH 03/10] ipmi: kcs_bmc: Make kcs_bmc_update_event_mask() static

From: Andrew Jeffery
Date: Sun Nov 05 2023 - 17:52:51 EST


On Fri, 2023-11-03 at 14:40 +0000, Jonathan Cameron wrote:
> On Fri, 3 Nov 2023 16:45:15 +1030
> Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > There were no users outside the subsystem core, so let's not expose it.
> >
> > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>
> Is it worth having the wrapper?

Perhaps not, though aesthetically I prefer it. Also the diff is at
least slightly smaller by not removing it entirely :)

>
> I guess all the other cases do have wrappers (even if that's because
> they continue to be exported) so fair enough.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Thanks,

Andrew