[PATCH] fs: dlm: Remove impossible to hit if statement

From: Joey Pabalinas
Date: Sun Nov 05 2023 - 17:22:33 EST


Signed-off-by: Joey Pabalinas <joeypabalinas@xxxxxxxxx>
---
fs/dlm/member.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/fs/dlm/member.c b/fs/dlm/member.c
index be7909ead71b427aa5..bf7085f21a708ab860 100644
--- a/fs/dlm/member.c
+++ b/fs/dlm/member.c
@@ -294,19 +294,14 @@ static void add_ordered_member(struct dlm_ls
*ls, struct dlm_member *new)
memb = list_entry(tmp, struct dlm_member, list);
if (new->nodeid < memb->nodeid)
break;
}

- if (!memb)
- list_add_tail(newlist, head);
- else {
- /* FIXME: can use list macro here */
- newlist->prev = tmp->prev;
- newlist->next = tmp;
- tmp->prev->next = newlist;
- tmp->prev = newlist;
- }
+ newlist->prev = tmp->prev;
+ newlist->next = tmp;
+ tmp->prev->next = newlist;
+ tmp->prev = newlist;
}

static int add_remote_member(int nodeid)
{
int error;

base-commit: 1c41041124bd14dd6610da256a3da4e5b74ce6b1
--
Cheers,
Joey Pabalinas