Re: [PATCH 3/8] drm/loongson: Allow attach drm bridge driver by calling lsdc_output_init()
From: kernel test robot
Date: Sun Nov 05 2023 - 12:32:05 EST
Hi Sui,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.6 next-20231103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sui-Jingfeng/drm-loongson-Introduce-a-minimal-support-for-Loongson-VBIOS/20231030-034730
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20231029194607.379459-4-suijingfeng%40loongson.cn
patch subject: [PATCH 3/8] drm/loongson: Allow attach drm bridge driver by calling lsdc_output_init()
config: x86_64-randconfig-122-20231102 (https://download.01.org/0day-ci/archive/20231106/202311060159.WME8x93V-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/202311060159.WME8x93V-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311060159.WME8x93V-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/loongson/lsdc_output.c:555:5: sparse: sparse: symbol 'lsdc_encoder_init' was not declared. Should it be static?
>> drivers/gpu/drm/loongson/lsdc_output.c:578:5: sparse: sparse: symbol 'lsdc_connector_init' was not declared. Should it be static?
vim +/lsdc_encoder_init +555 drivers/gpu/drm/loongson/lsdc_output.c
554
> 555 int lsdc_encoder_init(struct drm_device *ddev,
556 struct lsdc_output *output,
557 unsigned int pipe)
558 {
559 const struct lsdc_output_desc *descp = output->descp;
560 struct drm_encoder *encoder = &output->encoder;
561 int ret;
562
563 ret = drm_encoder_init(ddev,
564 encoder,
565 descp->encoder_funcs,
566 descp->encoder_type,
567 descp->name);
568 if (ret)
569 return ret;
570
571 encoder->possible_crtcs = BIT(pipe);
572
573 drm_encoder_helper_add(encoder, descp->encoder_helper_funcs);
574
575 return 0;
576 }
577
> 578 int lsdc_connector_init(struct drm_device *ddev,
579 struct lsdc_output *output,
580 struct i2c_adapter *ddc,
581 unsigned int pipe)
582 {
583 const struct lsdc_output_desc *descp = output->descp;
584 struct drm_connector *connector = &output->connector;
585 int ret;
586
587 ret = drm_connector_init_with_ddc(ddev,
588 connector,
589 descp->connector_funcs,
590 descp->connector_type,
591 ddc);
592 if (ret)
593 return ret;
594
595 drm_connector_helper_add(connector, descp->connector_helper_funcs);
596
597 drm_connector_attach_encoder(connector, &output->encoder);
598
599 connector->polled = DRM_CONNECTOR_POLL_CONNECT |
600 DRM_CONNECTOR_POLL_DISCONNECT;
601
602 connector->interlace_allowed = 0;
603 connector->doublescan_allowed = 0;
604
605 drm_info(ddev, "DisplayPipe-%u has %s\n", pipe, descp->name);
606
607 return 0;
608 }
609
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki