drivers/spi/spi-armada-3700.c:788:34: warning: 'a3700_spi_dt_ids' defined but not used

[kernel test robot]

Hi Romain,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1c41041124bd14dd6610da256a3da4e5b74ce6b1
commit: 5762ab71eb24a8393a167361510d7ca5e18c99f9 spi: Add support for Armada 3700 SPI Controller
date:   7 years ago
config: i386-buildonly-randconfig-005-20231101 (https://download.01.org/0day-ci/archive/20231105/202311051927.Yvv2LqvE-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311051927.Yvv2LqvE-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311051927.Yvv2LqvE-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/spi/spi-armada-3700.c: In function 'a3700_spi_probe':
   drivers/spi/spi-armada-3700.c:850:22: warning: comparison of unsigned expression in '< 0' is always false [-Wtype-limits]
     850 |         if (spi->irq < 0) {
         |                      ^
   drivers/spi/spi-armada-3700.c: At top level:
>> drivers/spi/spi-armada-3700.c:788:34: warning: 'a3700_spi_dt_ids' defined but not used [-Wunused-const-variable=]
     788 | static const struct of_device_id a3700_spi_dt_ids[] = {
         |                                  ^~~~~~~~~~~~~~~~


vim +/a3700_spi_dt_ids +788 drivers/spi/spi-armada-3700.c

   787	
 > 788	static const struct of_device_id a3700_spi_dt_ids[] = {
   789		{ .compatible = "marvell,armada-3700-spi", .data = NULL },
   790		{},
   791	};
   792	
   793	MODULE_DEVICE_TABLE(of, a3700_spi_dt_ids);
   794	
   795	static int a3700_spi_probe(struct platform_device *pdev)
   796	{
   797		struct device *dev = &pdev->dev;
   798		struct device_node *of_node = dev->of_node;
   799		struct resource *res;
   800		struct spi_master *master;
   801		struct a3700_spi *spi;
   802		u32 num_cs = 0;
   803		int ret = 0;
   804	
   805		master = spi_alloc_master(dev, sizeof(*spi));
   806		if (!master) {
   807			dev_err(dev, "master allocation failed\n");
   808			ret = -ENOMEM;
   809			goto out;
   810		}
   811	
   812		if (of_property_read_u32(of_node, "num-cs", &num_cs)) {
   813			dev_err(dev, "could not find num-cs\n");
   814			ret = -ENXIO;
   815			goto error;
   816		}
   817	
   818		master->bus_num = pdev->id;
   819		master->dev.of_node = of_node;
   820		master->mode_bits = SPI_MODE_3;
   821		master->num_chipselect = num_cs;
   822		master->bits_per_word_mask = SPI_BPW_MASK(8) | SPI_BPW_MASK(32);
   823		master->prepare_message =  a3700_spi_prepare_message;
   824		master->transfer_one = a3700_spi_transfer_one;
   825		master->unprepare_message = a3700_spi_unprepare_message;
   826		master->set_cs = a3700_spi_set_cs;
   827		master->flags = SPI_MASTER_HALF_DUPLEX;
   828		master->mode_bits |= (SPI_RX_DUAL | SPI_RX_DUAL |
   829				      SPI_RX_QUAD | SPI_TX_QUAD);
   830	
   831		platform_set_drvdata(pdev, master);
   832	
   833		spi = spi_master_get_devdata(master);
   834		memset(spi, 0, sizeof(struct a3700_spi));
   835	
   836		spi->master = master;
   837		spi->instr_cnt = A3700_INSTR_CNT;
   838		spi->addr_cnt = A3700_ADDR_CNT;
   839		spi->hdr_cnt = A3700_INSTR_CNT + A3700_ADDR_CNT +
   840			       A3700_DUMMY_CNT;
   841	
   842		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   843		spi->base = devm_ioremap_resource(dev, res);
   844		if (IS_ERR(spi->base)) {
   845			ret = PTR_ERR(spi->base);
   846			goto error;
   847		}
   848	
   849		spi->irq = platform_get_irq(pdev, 0);
 > 850		if (spi->irq < 0) {
   851			dev_err(dev, "could not get irq: %d\n", spi->irq);
   852			ret = -ENXIO;
   853			goto error;
   854		}
   855	
   856		init_completion(&spi->done);
   857	
   858		spi->clk = devm_clk_get(dev, NULL);
   859		if (IS_ERR(spi->clk)) {
   860			dev_err(dev, "could not find clk: %ld\n", PTR_ERR(spi->clk));
   861			goto error;
   862		}
   863	
   864		ret = clk_prepare(spi->clk);
   865		if (ret) {
   866			dev_err(dev, "could not prepare clk: %d\n", ret);
   867			goto error;
   868		}
   869	
   870		ret = a3700_spi_init(spi);
   871		if (ret)
   872			goto error_clk;
   873	
   874		ret = devm_request_irq(dev, spi->irq, a3700_spi_interrupt, 0,
   875				       dev_name(dev), master);
   876		if (ret) {
   877			dev_err(dev, "could not request IRQ: %d\n", ret);
   878			goto error_clk;
   879		}
   880	
   881		ret = devm_spi_register_master(dev, master);
   882		if (ret) {
   883			dev_err(dev, "Failed to register master\n");
   884			goto error_clk;
   885		}
   886	
   887		return 0;
   888	
   889	error_clk:
   890		clk_disable_unprepare(spi->clk);
   891	error:
   892		spi_master_put(master);
   893	out:
   894		return ret;
   895	}
   896	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki