Re: [PATCH 3/6] selftests/nolibc: use XARCH for MIPS

From: Thomas Weißschuh
Date: Sun Nov 05 2023 - 05:49:14 EST


On 2023-11-05 11:32:27+0100, Willy Tarreau wrote:
> On Sun, Nov 05, 2023 at 11:09:57AM +0100, Thomas Weißschuh wrote:
> > MIPS has many different configurations prepare the support of additional
> > ones by moving the build of MIPS to the generic XARCH infrastructure.
> >
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > ---
> > tools/testing/selftests/nolibc/Makefile | 12 +++++++-----
> > tools/testing/selftests/nolibc/run-tests.sh | 2 +-
> > 2 files changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
> > index c5df1617cbc3..15c12f3c27ba 100644
> > --- a/tools/testing/selftests/nolibc/Makefile
> > +++ b/tools/testing/selftests/nolibc/Makefile
> > @@ -40,12 +40,14 @@ objtree ?= $(srctree)
> >
> > # configure default variants for target kernel supported architectures
> > XARCH_powerpc = ppc
> > +XARCH_mips = mipso32le
> > XARCH = $(or $(XARCH_$(ARCH)),$(ARCH))
> >
> > # map from user input variants to their kernel supported architectures
> > ARCH_ppc = powerpc
> > ARCH_ppc64 = powerpc
> > ARCH_ppc64le = powerpc
> > +ARCH_mipso32le = mips
>
> I *think* that what you called "mipso32le" above corresponds exactly to
> what is commonly called "mips32le" in toolchains or distros, because,
> unless I'm mistaken, "mips32" currently uses the O32 ABI. So that would
> sound more intuitive and natural I think.

Ack.

I did the same for mipso32be -> mips32be.

Thomas