Re: [PATCH] net: phy: at803x: add QCA8084 ethernet phy support

[Jie Luo]

On 11/4/2023 10:19 PM, Andrew Lunn wrote:
> On Sat, Nov 04, 2023 at 02:25:25PM +0800, Jie Luo wrote:
> > On 11/3/2023 9:01 PM, Andrew Lunn wrote:
> > > >    #define QCA8081_PHY_ID				0x004dd101
> > > > +#define QCA8081_PHY_MASK			0xffffff00
> > >
> > > That is an unusual mask. Please check it is correct. All you should
> > > need its PHY_ID_MATCH_EXACT, PHY_ID_MATCH_MODEL, PHY_ID_MATCH_VENDOR.
> >
> > Thanks Andrew for the review.
> > The PHY ID of qca8084 is correct, i will update to use PHY_ID_MATCH_EXACT in
> > the new added entry for qca8084.
>
> Note, i asked about the mask, not the ID. Is PHY_ID_MATCH_EXACT maybe
> too exact? Is there the option for different revisions of the PHY? Can
> one entry in the table be used for multiple revisions?
>
>
>      Andrew
>
> ---
> pw-bot: cr

Sure, Andrew, qca8084 is the different model chip from qca8081, and 
there is only one PHY ID used currently for the qca8084(4-port) and 
qca8082(2-port), but we can use PHY_ID_MATCH_MODEL for new added entry 
of qca8084 and qca8082.