Re: fs/smb/server/vfs.c:1207: warning: Function parameter or member 'parent_path' not described in 'ksmbd_vfs_kern_path_locked'
From: Namjae Jeon
Date: Sat Nov 04 2023 - 22:45:04 EST
2023-11-04 21:36 GMT+09:00, kernel test robot <lkp@xxxxxxxxx>:
> Hi Namjae,
Hi,
>
> FYI, the error/warning still remains.
I have fixed it:). I will apply it soon.
Thanks for your report!
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 90b0c2b2edd1adff742c621e246562fbefa11b70
> commit: 2b57a4322b1b14348940744fdc02f9a86cbbdbeb ksmbd: check if a mount
> point is crossed during path lookup
> date: 3 months ago
> config: sh-allyesconfig
> (https://download.01.org/0day-ci/archive/20231104/202311042024.12w45Xsm-lkp@xxxxxxxxx/config)
> compiler: sh4-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build):
> (https://download.01.org/0day-ci/archive/20231104/202311042024.12w45Xsm-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version
> of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes:
> https://lore.kernel.org/oe-kbuild-all/202311042024.12w45Xsm-lkp@xxxxxxxxx/
>
> All warnings (new ones prefixed by >>):
>
> fs/smb/server/vfs.c:54: warning: Function parameter or member 'parent'
> not described in 'ksmbd_vfs_lock_parent'
> fs/smb/server/vfs.c:54: warning: Function parameter or member 'child' not
> described in 'ksmbd_vfs_lock_parent'
> fs/smb/server/vfs.c:375: warning: Function parameter or member 'fp' not
> described in 'ksmbd_vfs_read'
> fs/smb/server/vfs.c:375: warning: Excess function parameter 'fid'
> description in 'ksmbd_vfs_read'
> fs/smb/server/vfs.c:492: warning: Function parameter or member 'fp' not
> described in 'ksmbd_vfs_write'
> fs/smb/server/vfs.c:492: warning: Excess function parameter 'fid'
> description in 'ksmbd_vfs_write'
> fs/smb/server/vfs.c:555: warning: Function parameter or member 'path' not
> described in 'ksmbd_vfs_getattr'
> fs/smb/server/vfs.c:555: warning: Function parameter or member 'stat' not
> described in 'ksmbd_vfs_getattr'
> fs/smb/server/vfs.c:555: warning: Excess function parameter 'work'
> description in 'ksmbd_vfs_getattr'
> fs/smb/server/vfs.c:555: warning: Excess function parameter 'fid'
> description in 'ksmbd_vfs_getattr'
> fs/smb/server/vfs.c:555: warning: Excess function parameter 'attrs'
> description in 'ksmbd_vfs_getattr'
> fs/smb/server/vfs.c:572: warning: Function parameter or member 'p_id' not
> described in 'ksmbd_vfs_fsync'
> fs/smb/server/vfs.c:595: warning: Function parameter or member 'work' not
> described in 'ksmbd_vfs_remove_file'
> fs/smb/server/vfs.c:595: warning: Function parameter or member 'path' not
> described in 'ksmbd_vfs_remove_file'
> fs/smb/server/vfs.c:595: warning: Excess function parameter 'name'
> description in 'ksmbd_vfs_remove_file'
> fs/smb/server/vfs.c:638: warning: Function parameter or member 'work' not
> described in 'ksmbd_vfs_link'
> fs/smb/server/vfs.c:815: warning: Function parameter or member 'fp' not
> described in 'ksmbd_vfs_truncate'
> fs/smb/server/vfs.c:815: warning: Excess function parameter 'fid'
> description in 'ksmbd_vfs_truncate'
> fs/smb/server/vfs.c:856: warning: Excess function parameter 'size'
> description in 'ksmbd_vfs_listxattr'
> fs/smb/server/vfs.c:933: warning: Function parameter or member 'path' not
> described in 'ksmbd_vfs_setxattr'
> fs/smb/server/vfs.c:933: warning: Excess function parameter 'dentry'
> description in 'ksmbd_vfs_setxattr'
> fs/smb/server/vfs.c:958: warning: Function parameter or member 'option'
> not described in 'ksmbd_vfs_set_fadvise'
> fs/smb/server/vfs.c:958: warning: Excess function parameter 'options'
> description in 'ksmbd_vfs_set_fadvise'
> fs/smb/server/vfs.c:1172: warning: Function parameter or member 'um' not
> described in 'ksmbd_vfs_lookup_in_dir'
> fs/smb/server/vfs.c:1207: warning: Function parameter or member 'work'
> not described in 'ksmbd_vfs_kern_path_locked'
>>> fs/smb/server/vfs.c:1207: warning: Function parameter or member
>>> 'parent_path' not described in 'ksmbd_vfs_kern_path_locked'
>
>
> vim +1207 fs/smb/server/vfs.c
>
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1194
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1195 /**
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1196 *
> ksmbd_vfs_kern_path_locked() - lookup a file and get path info
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1197 *
> @name: file path that is relative to share
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1198 *
> @flags: lookup flags
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1199 *
> @path: if lookup succeed, return path info
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1200 *
> @caseless: caseless filename lookup
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1201 *
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1202 *
> Return: 0 on success, otherwise error
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1203 */
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1204 int
> ksmbd_vfs_kern_path_locked(struct ksmbd_work *work, char *name,
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1205
> unsigned int flags, struct path *parent_path,
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1206
> struct path *path, bool caseless)
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 @1207 {
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1208 struct
> ksmbd_share_config *share_conf = work->tcon->share_conf;
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1209 int
> err;
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1210
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1211 err =
> ksmbd_vfs_path_lookup_locked(share_conf, name, flags, parent_path,
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1212
> path);
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1213 if
> (!err)
> cf5e7f734f4455 fs/smb/server/vfs.c Namjae Jeon 2023-05-30 1214 return
> 0;
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1215
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1216 if
> (caseless) {
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1217 char
> *filepath;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1218 size_t
> path_len, remain_len;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1219
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1220
> filepath = kstrdup(name, GFP_KERNEL);
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1221 if
> (!filepath)
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1222 return
> -ENOMEM;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1223
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1224
> path_len = strlen(filepath);
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1225
> remain_len = path_len;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1226
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1227
> *parent_path = share_conf->vfs_path;
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1228
> path_get(parent_path);
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1229
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1230 while
> (d_can_lookup(parent_path->dentry)) {
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1231 char
> *filename = filepath + path_len - remain_len;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1232 char
> *next = strchrnul(filename, '/');
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1233 size_t
> filename_len = next - filename;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1234 bool
> is_last = !next[0];
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1235
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1236 if
> (filename_len == 0)
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1237
> break;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1238
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1239 err =
> ksmbd_vfs_lookup_in_dir(parent_path, filename,
> dbab80e2071ad8 fs/ksmbd/vfs.c Atte Heikkilä 2022-09-28 1240
> filename_len,
> dbab80e2071ad8 fs/ksmbd/vfs.c Atte Heikkilä 2022-09-28 1241
> work->conn->um);
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1242 if
> (err)
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1243 goto
> out2;
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1244
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1245
> next[0] = '\0';
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1246
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1247 err =
> vfs_path_lookup(share_conf->vfs_path.dentry,
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1248
> share_conf->vfs_path.mnt,
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1249
> filepath,
> 265fd1991c1db8 fs/ksmbd/vfs.c Hyunchul Lee 2021-09-25 1250
> flags,
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1251
> path);
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1252 if
> (err)
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1253 goto
> out2;
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1254 else
> if (is_last)
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1255 goto
> out1;
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1256
> path_put(parent_path);
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1257
> *parent_path = *path;
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1258
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1259
> next[0] = '/';
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1260
> remain_len -= filename_len + 1;
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1261 }
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1262
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1263 err =
> -EINVAL;
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1264 out2:
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1265
> path_put(parent_path);
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1266 out1:
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1267
> kfree(filepath);
> 3c20378325c710 fs/cifsd/vfs.c Hyunchul Lee 2021-04-13 1268 }
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1269
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1270 if
> (!err) {
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1271 err =
> ksmbd_vfs_lock_parent(parent_path->dentry, path->dentry);
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1272 if
> (err) {
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1273
> path_put(path);
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1274
> path_put(parent_path);
> 2b57a4322b1b14 fs/smb/server/vfs.c Namjae Jeon 2023-07-17 1275 }
> 74d7970febf7e9 fs/ksmbd/vfs.c Namjae Jeon 2023-04-21 1276 }
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1277 return
> err;
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1278 }
> f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1279
>
> :::::: The code at line 1207 was first introduced by commit
> :::::: f44158485826c076335d6860d35872271a83791d cifsd: add file operations
>
> :::::: TO: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> :::::: CC: Steve French <stfrench@xxxxxxxxxxxxx>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>