Re: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

[Duje Mihanović]

On Friday, November 3, 2023 4:34:54 PM CET Robin Murphy wrote:
> On 2023-11-02 3:20 pm, Duje Mihanović wrote:
> > +config ARCH_MMP
> > +	bool "Marvell MMP SoC Family"
> > +	select ARM_GIC
> > +	select ARM_ARCH_TIMER
> > +	select ARM_SMMU
> 
> NAK, not only is selecting user-visible symbols generally frowned upon,
> and ignoring their dependencies even worse, but for a multiplatform
> kernel the user may well want this to be a module.
> 
> If having the SMMU driver built-in is somehow fundamentally required for
> this platform to boot, that would represent much bigger problems.

The SoC can boot without SMMU and PDMA, but not GIC, pinctrl or the arch 
timer. I see that most other SoCs still select drivers and frameworks they 
presumably need for booting, with the exceptions of ARCH_BITMAIN, ARCH_LG1K 
and a couple others. Which of these two options should I go for?

Regards,
Duje