Re: [PATCH] efi/unaccepted: Fix off-by-one when checking for overlapping ranges

[Michael Roth]

On Fri, Nov 03, 2023 at 05:53:53PM +0300, Kirill A . Shutemov wrote:
> On Fri, Nov 03, 2023 at 09:26:50AM -0500, Michael Roth wrote:
> > When a thread needs to accept memory it will scan the accepting_list
> > to see if any ranges already being processed by other threads overlap
> > with its range. Due to an off-by-one in the range comparisons, a thread
> > might falsely determine that an overlapping range is being accepted,
> > leading to an unnecessary delay before it begins processing the range.
> 
> Maybe s/thread/task/g ?
> 
> > Fix the off-by-one in the range comparison to prevent this and slightly
> > improve performance.
> > 
> > Fixes: 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused by parallel memory acceptance")
> > Link: https://lore.kernel.org/linux-mm/20231101004523.vseyi5bezgfaht5i@xxxxxxx/T/#me2eceb9906fcae5fe958b3fe88e41f920f8335b6
> > Signed-off-by: Michael Roth <michael.roth@xxxxxxx>
> 
> Otherwise, looks good:
> 
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

Thanks! Sending a v2 with suggested changes.

-Mike

> > 
> 
> -- 
>   Kiryl Shutsemau / Kirill A. Shutemov