Re: [RFC PATCH 4/5] spi: qpic: Add support for qpic spi nand driver

[Md Sadre Alam]

On 10/31/2023 10:43 PM, Krzysztof Kozlowski wrote:
> On 31/10/2023 13:03, Md Sadre Alam wrote:
> > Add qpic spi nand driver support for qcom soc.
>
> What is "qcom soc"? Did you mean Qualcomm and SoC?

Yes Qualcomm SoC

> > Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
> > Signed-off-by: Sricharan R <quic_srichara@xxxxxxxxxxx>
> > ---
> >   drivers/spi/Kconfig          |   7 +
> >   drivers/spi/Makefile         |   1 +
> >   drivers/spi/spi-qpic-snand.c | 604 +++++++++++++++++++++++++++++++++++
> >   3 files changed, 612 insertions(+)
> >   create mode 100644 drivers/spi/spi-qpic-snand.c
>
> ...
>
> > +
> > +static int qcom_snand_remove(struct platform_device *pdev)
> > +{
> > +	struct spi_controller *ctlr = platform_get_drvdata(pdev);
> > +	spi_unregister_master(ctlr);
> > +
> > +	return 0;
> > +}
> > +
> > +static const struct qcom_nandc_props ipq9574_snandc_props = {
> > +	.dev_cmd_reg_start = 0x7000,
> > +	.is_bam = true,
> > +	.qpic_v2 = true,
> > +};
> > +
> > +static const struct of_device_id qcom_snandc_of_match[] = {
> > +	{
> > +		.compatible = "qcom,ipq9574-nand",
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.

Ok
> Best regards,
> Krzysztof