Re: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support

From: Md Sadre Alam
Date: Fri Nov 03 2023 - 08:10:02 EST




On 10/31/2023 10:42 PM, Krzysztof Kozlowski wrote:
On 31/10/2023 13:03, Md Sadre Alam wrote:
Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
Signed-off-by: Sricharan R <quic_srichara@xxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 5f83ee42a719..b44acb1fac74 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -336,6 +336,11 @@ sdhc_1: mmc@7804000 {
status = "disabled";
};
+ bch: qpic_ecc {
+ compatible = "qcom,ipq9574-ecc";

NAK. There are so many wrong things with it... Let's start with missing
checkpatch. Then with unndeeded label. Then with not allowed underscores
in node names.
Finally:
+ status = "ok";

Drop.

Ok


Best regards,
Krzysztof