Re: [GIT PULL] Crypto Update for 6.7

From: Linus Torvalds
Date: Fri Nov 03 2023 - 02:33:05 EST


On Thu, 2 Nov 2023 at 19:52, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Fair enough. How about adding an EXPERT dependency on this?

I think that would help the situation, but I assume the sizing for the
jitter buffer is at least partly due to trying to account for cache
sizing or similar issues?

Which really means that I assume any static compile-time answer to
that question is always wrong - whether you are an expert or not.
Unless you are just building the thing for one particular machine.

So I do think the problem is deeper than "this is a question only for
experts". I definitely don't think you should ask a regular user (or
even a distro kernel package manager). I suspect it's likely that the
question is just wrong in general - because any particular one buffer
size for any number of machines simply cannot be the right answer.

I realize that the commit says "*allow* for configuration of memory
size", but I really question the whole approach.

But yes - hiding these questions from any reasonable normal user is at
least a good first step.

Linus