Re: [PATCH v3 2/3] dt-bindings: arm: fsl: add RVE gateway board

[Hugo Villeneuve]

On Thu, 2 Nov 2023 22:14:41 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> On 02/11/2023 20:31, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > 
> > Add DT compatible string for RVE gateway board based on a Variscite
> > VAR-SOM-NANO with a NXP MX8MN nano CPU.
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 32b195852a75..4cef18e46312 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1018,6 +1018,7 @@ properties:
> >                - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
> >                - fsl,imx8mn-evk            # i.MX8MN LPDDR4 EVK Board
> >                - gw,imx8mn-gw7902          # i.MX8MM Gateworks Board
> > +              - rve,rve-gateway           # i.MX8MN RVE Gateway Board
> 
> Eh, now it does not match your DTS.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

Hi,
for the millionth time, make dtbs_check stopped working for me:

Traceback (most recent call last):
  File "/usr/local/bin/dt-doc-validate", line 64, in <module>
    ret |= check_doc(f)
           ^^^^^^^^^^^^
  File "/usr/local/bin/dt-doc-validate", line 32, in check_doc
    for error in sorted(dtsch.iter_errors(), key=lambda e: e.linecol):
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py",
line 125, in iter_errors self.annotate_error(scherr, meta_schema,
scherr.schema_path) File
"/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 104,
in annotate_error schema = schema[p] ~~~~~~^^^

After a few hours of searching and troubleshooting, I am unable to fix
the problem.

But even with this error, I can still see the warnings, which I
discarded as garbage initally because of that Traceback error.

I now see the problem, and I moved "rve,rve-gateway" to the proper
section, in "Variscite VAR-SOM-MX8MN based boards".

After the move, I still have an error, but now I understand that I must
slightly convert the "Variscite VAR-SOM-MX8MN based boards" to support
more than one board like this:

       - description: Variscite VAR-SOM-MX8MN based boards
         items:
-          - const: variscite,var-som-mx8mn-symphony
+          - enum:
+              - rve,rve-gateway # i.MX8MN RVE Gateway Board
+              - variscite,var-som-mx8mn-symphony
           - const: variscite,var-som-mx8mn
           - const: fsl,imx8mn

With these changes, everything looks good now.

I Will send a V4 with these changes.

Thank you,
Hugo.