Re: [PATCH v4 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test

From: Axel Rasmussen
Date: Thu Nov 02 2023 - 17:32:49 EST


On Mon, Oct 30, 2023 at 1:14 PM Peter Xu <peterx@xxxxxxxxxx> wrote:
>
> On Fri, Oct 27, 2023 at 05:38:13PM -0700, Suren Baghdasaryan wrote:
> > uffd_test_ctx_clear() is being called from uffd_test_ctx_init() to unmap
> > areas used in the previous test run. This approach is problematic because
> > while unmapping areas uffd_test_ctx_clear() uses page_size and nr_pages
> > which might differ from one test run to another.
> > Fix this by calling uffd_test_ctx_clear() after each test is done.
> >
> > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>
> Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

Looks correct to me as well. Thanks for fixing this, Suren!

Reviewed-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx>

>
> --
> Peter Xu
>