Re: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from run_cmd_parmap

[Julia Lawall]

----- Mail original -----
> De: "Anton Eliasson" <anton.eliasson@xxxxxxxx>
> À: "Julia Lawall" <Julia.Lawall@xxxxxxxx>, "nicolas palix" <nicolas.palix@xxxxxxx>
> Cc: "cocci" <cocci@xxxxxxxx>, "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>, "Anton Eliasson" <anton.eliasson@xxxxxxxx>,
> kernel@xxxxxxxx
> Envoyé: Mardi 3 Octobre 2023 16:25:14
> Objet: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from run_cmd_parmap

> Exiting on error breaks the chain mode. Return the error instead in
> order for the caller to propagate it or in the case of chain, try the
> next mode.
> 
> Signed-off-by: Anton Eliasson <anton.eliasson@xxxxxxxx>
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index e52cb43fede6..95a312730e98 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -153,7 +153,7 @@ run_cmd_parmap() {
> 	err=$?
> 	if [[ $err -ne 0 ]]; then
> 		echo "coccicheck failed"
> -		exit $err
> +		return $err
> 	fi
> }
> 

I tried disabling OCaml in my version of Coccinelle and then ran make coccicheck with this patch.  But I didn't see any improvement.  On the other hand, it keeps going if I just remove the exit line entirely.  Is that what is wanted?  One can still see the coccicheck failed message.

julia

> --
> 2.30.2