Re: [PATCH] soc: mediatek: mmsys: Add support for MT8188 VPPSYS

[AngeloGioacchino Del Regno]

Il 02/11/23 12:33, yu-chang.lee ha scritto:
> Add MT8188 VPPSYS0 and VPPSYS1 driver data.
>
> Signed-off-by: yu-chang.lee <yu-chang.lee@xxxxxxxxxxxx>

This change is valid, but you have to reflect that in the bindings.
Remove mediatek,mt8188-vppsys{0,1} from clock/mediatek,mt8188-clock.yaml and add
those to arm/mediatek/mediatek,mmsys.yaml like was done with MT8195.

Of course, bindings go to a separate commit.

I can't give you a R-b tag for this one without the bindings one..... :-)

Thanks,
Angelo

> ---
>   drivers/soc/mediatek/mtk-mmsys.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 7630e1d9b3a4..591e92468bea 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -89,6 +89,16 @@ static const struct mtk_mmsys_driver_data mt8188_vdosys0_driver_data = {
>   	.num_routes = ARRAY_SIZE(mmsys_mt8188_routing_table),
>   };
>   
> +static const struct mtk_mmsys_driver_data mt8188_vppsys0_driver_data = {
> +	.clk_driver = "clk-mt8188-vpp0",
> +	.is_vppsys = true,
> +};
> +
> +static const struct mtk_mmsys_driver_data mt8188_vppsys1_driver_data = {
> +	.clk_driver = "clk-mt8188-vpp1",
> +	.is_vppsys = true,
> +};
> +
>   static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = {
>   	.clk_driver = "clk-mt8192-mm",
>   	.routes = mmsys_mt8192_routing_table,
> @@ -440,6 +450,8 @@ static const struct of_device_id of_match_mtk_mmsys[] = {
>   	{ .compatible = "mediatek,mt8183-mmsys", .data = &mt8183_mmsys_driver_data },
>   	{ .compatible = "mediatek,mt8186-mmsys", .data = &mt8186_mmsys_driver_data },
>   	{ .compatible = "mediatek,mt8188-vdosys0", .data = &mt8188_vdosys0_driver_data },
> +	{ .compatible = "mediatek,mt8188-vppsys0", .data = &mt8188_vppsys0_driver_data },
> +	{ .compatible = "mediatek,mt8188-vppsys1", .data = &mt8188_vppsys1_driver_data },
>   	{ .compatible = "mediatek,mt8192-mmsys", .data = &mt8192_mmsys_driver_data },
>   	/* "mediatek,mt8195-mmsys" compatible is deprecated */
>   	{ .compatible = "mediatek,mt8195-mmsys", .data = &mt8195_vdosys0_driver_data },