Re: [Patch v13 4/9] wifi: mac80211: Add support for WBRF features

[Johannes Berg]

On Thu, 2023-11-02 at 13:55 +0200, Ilpo Järvinen wrote:


[please trim your quotes]

> > +static void get_chan_freq_boundary(u32 center_freq, u32 bandwidth, u64 *start, u64 *end)
> > +{
> > +	bandwidth = MHZ_TO_KHZ(bandwidth);
> > +	center_freq = MHZ_TO_KHZ(center_freq);
> 
> Please use include/linux/units.h ones for these too.

Now we're feature creeping though - this has existed for *years* in the
wireless stack with many instances? We can convert them over, I guess,
but not sure that makes much sense here - we'd want to add such macros
to units.h, but ... moving them can be independent of this patch?

johannes