Re: [PATCH v7] misc: Add Nitro Secure Module driver

From: Greg Kroah-Hartman
Date: Thu Nov 02 2023 - 07:30:14 EST


On Thu, Nov 02, 2023 at 10:54:34AM +0100, Alexander Graf wrote:
> On 11.10.23 23:35, Alexander Graf wrote:
> > When running Linux inside a Nitro Enclave, the hypervisor provides a
> > special virtio device called "Nitro Security Module" (NSM). This device
> > has 3 main functions:
> >
> > 1) Provide attestation reports
> > 2) Modify PCR state
> > 3) Provide entropy
> >
> > This patch adds a driver for NSM that exposes a /dev/nsm device node which
> > user space can issue an ioctl on this device with raw NSM CBOR formatted
> > commands to request attestation documents, influence PCR states, read
> > entropy and enumerate status of the device. In addition, the driver
> > implements a hwrng backend.
> >
> > Originally-by: Petre Eftime <petre.eftime@xxxxxxxxx>
> > Signed-off-by: Alexander Graf <graf@xxxxxxxxxx>
>
>
> Ping for inclusion? I haven't seen any further comments on v7 of this patch,
> so I'd assume it's good to go? :)

Ah, I thought there would be a new version for some reason, sorry about
that. I'll review it after -rc1 is out, in the middle of the merge
window right now, I can't add anything to my trees, but new drivers can
always be added after that.

thanks,

greg k-h