Re: [PATCH 08/10] drm/tidss: Add dispc_is_idle()

From: Tomi Valkeinen
Date: Thu Nov 02 2023 - 03:03:34 EST


On 01/11/2023 16:32, Laurent Pinchart wrote:
Hi Tomi,

Thank you for the patch.

On Wed, Nov 01, 2023 at 11:17:45AM +0200, Tomi Valkeinen wrote:
Add a helper function, dispc_is_idle(), which returns whether the DSS is
idle (i.e. is any video port enabled).

For now we add a call to it in the suspend and resume callbacks, and
print a warning if in either place the DSS is not idle.

Could you please explain here why these checks are needed/useful ? Why
would the dispc not be idle ?

I'll drop this. This was mostly a debugging aid for myself when testing runtime PM.

Tomi