RE: [EXT] Re: [PATCH net v1 2/2] octeontx2-pf: Fix holes in error code

From: Ratheesh Kannoth
Date: Wed Nov 01 2023 - 22:31:54 EST


> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Subject: [EXT] Re: [PATCH net v1 2/2] octeontx2-pf: Fix holes in error code
>
> On Fri, 2023-10-27 at 07:49 +0530, Ratheesh Kannoth wrote:
> > Error code strings are not getting printed properly due to holes.
> > Print error code as well.
> error",
> > qidx);
> > if (val & BIT_ULL(NIX_CQERRINT_CQE_FAULT))
> > - netdev_err(pf->netdev, "CQ%lld: Memory
> fault on CQE write to LLC/DRAM",
> > + netdev_err(pf->netdev,
> > + "CQ%lld: Memory fault on CQE
> write to LLC/DRAM",
> > qidx);
> > }
>
> It's not a big deal (no need to repost just for this), but the above chunk (and
> a couple below, too) is not related to the current fix, you should have not
> included it here.
I understand your point. But, Commit message says "Print error code as well". When I added code to print it, it crossed 80 column mark,
so checkpatch script threw warning. So I splitted lines. Actually , there is not much change here.

-Ratheesh