Re: [PATCH] dt-bindings: power: reset: $ref reboot-mode in nvmem-reboot-mode

[Mukesh Ojha]

On 10/31/2023 11:58 PM, Elliot Berman wrote:
> nvmem-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
> rewrites the properties. Update so it $refs instead.
>
> Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>

Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh

> ---
>   .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml        | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> index 14a262bcbf7c..627f8a6078c2 100644
> --- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> @@ -28,17 +28,15 @@ properties:
>       items:
>         - const: reboot-mode
>   
> -patternProperties:
> -  "^mode-.+":
> -    $ref: /schemas/types.yaml#/definitions/uint32
> -    description: Vendor-specific mode value written to the mode register
> +allOf:
> +  - $ref: reboot-mode.yaml#
>   
>   required:
>     - compatible
>     - nvmem-cells
>     - nvmem-cell-names
>   
> -additionalProperties: false
> +unevaluatedProperties: false
>   
>   examples:
>     - |
>
> ---
> base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa
> change-id: 20231031-ref-nvmem-reboot-mode-1369970436e4
>
> Best regards,