Re: [PATCH v1] hwmon: emc1403: Add support for EMC1442

[Patrick Williams]

On Wed, Nov 01, 2023 at 08:45:15AM +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> > >>> ---
> > >>>     { "emc1422", emc1402 },
> > >>>     { "emc1423", emc1403 },
> > >>>     { "emc1424", emc1404 },
> > >>> +   { "emc1442", emc1403 },
> > >
> > > So, emc1402?
> > >
> > 
> > At the very least, if you are willing to confirm that formally if/when v2 is
> > submitted.
> > 
> > I previously rejected a similar patch adding emc1444 because it was impossible
> > to get a datasheet to confirm that the chips are really register compatible. No
> > idea why that has to be so secretive. It is a temperature sensor, for heaven's
> > sake :-(
> > 
> > Guenter
> 
> Hi Krish,
> Would need your confirmation of the device on the NIC.

I don't think we need additional feedback from Krish.  Please change to
emc1402 from emc1403.

The datasheet for EMC1442 even has a section titled "Functional Delta
from EMC1412 to EMC1442", which is effectively all non-software related.
Therefore, the compatibility here should match what was done for
"emc1412" which was `emc1402`.

I will send my Reviewed-by with a v2 using emc1402.

-- 
Patrick Williams

Attachment: signature.asc
Description: PGP signature