Re: [PATCH] tty: hso: Fix potential null pointer dereference

From: Greg KH
Date: Wed Nov 01 2023 - 10:20:22 EST


On Wed, Nov 01, 2023 at 09:35:44PM +0800, Ren Mingshuai wrote:
> Generally, the old always points to the address of a ktermios structure,
> so old is unlikely to be NULL. Still check it before dereference as
> elsewhere.

If it can not happen, there is no need to check it. So unless you can
prove that this ever could happen, this change isn't needed, right?

thanks,

greg k-h