Re: [PATCH v2] coresight: etm4x: Fix width of CCITMIN field

[Suzuki K Poulose]

On 01/11/2023 11:52, James Clark wrote:
> CCITMIN is a 12 bit field and doesn't fit in a u8, so extend it to u16.
> This probably wasn't an issue previously because values higher than 255
> never occurred.
>
> But since commit 0f55b43dedcd ("coresight: etm: Override TRCIDR3.CCITMIN
> on errata affected cpus"), a comparison with 256 was done to enable the
> errata, generating the following W=1 build error:
>
>    coresight-etm4x-core.c:1188:24: error: result of comparison of
>    constant 256 with expression of type 'u8' (aka 'unsigned char') is
>    always false [-Werror,-Wtautological-constant-out-of-range-compare]
>
>     if (drvdata->ccitmin == 256)
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 2e1cdfe184b5 ("coresight-etm4x: Adding CoreSight ETM4x driver")
> Reviewed-by: Mike Leach <mike.leach@xxxxxxxxxx>
> Signed-off-by: James Clark <james.clark@xxxxxxx>

Thanks, applied to coresight next :


Suzuki