Re: [net-next PATCH v2 2/2] dt-bindings: Document bindings for Marvell Aquantia PHY

[Andrew Lunn]

> +  Marvell Aquantia Ethernet PHY require a firmware to be loaded to actually
> +  work.
> +
> +  This can be done and is implemented by OEM in 3 different way:
> +    - Attached SPI directly to the PHY with the firmware. The PHY will
> +      self load the firmware in the presence of this configuration.
> +    - Dedicated partition on system NAND with firmware in it. NVMEM
> +      subsystem will be used and the declared NVMEM cell will load
> +      the firmware to the PHY using the PHY mailbox interface.
> +    - Manually provided firmware using the sysfs interface. Firmware is
> +      loaded using the PHY mailbox.

sysfs is a linux concept. DT bindings should be OS agnostic. It would
be better to say its loaded from a file in the file system.

I'm not sure mailbox is relevant here. All you really are trying to
say is that if there is an SPI flash, the PHY will load the firmware
itself. If not the driver will load the firmware.

	Andrew