Re: [PATCH 1/1] Revert "media: imx290: Convert to new CCI register access helpers"

From: Sakari Ailus
Date: Wed Nov 01 2023 - 06:32:00 EST


Hi Alexander,

On Wed, Nov 01, 2023 at 11:09:00AM +0100, Alexander Stein wrote:
> cci_write() unconditionally writes multi-byte data in big-endian format.
> But IMX290 and IMX327 use little-endian format for multi-byte registers.
> Revert the CCI usage until little-endian is supported by CCI register
> access helpers.
> This reverts commit af73323b97702e53b0a336972aaf23e7dd92c850.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
> The difference is subtile, but imx290_write() uses put_unaligned_le24(),
> while cci_write() uses put_unaligned_be24().
>
> I assume this should go into stable as well. How to deal with that?
> Shall a revert get the fixes tag as well?

I'd very much prefer addressing this in v4l2-cci instead. It should also be
a much smaller patch (or patches).

--
Regards,

Sakari Ailus