Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case

From: Andy Shevchenko
Date: Wed Nov 01 2023 - 05:35:10 EST


On Wed, Nov 01, 2023 at 08:35:20AM +0200, Mika Westerberg wrote:
> On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote:

...

> > + case 1: /* Set default strength value in case none is given */
>
> The comment is good but I think would it make sense to have constant for
> this instead?

If so, it makes sense to get it via entire GPIO library, and not locally for
Intel stuff. That said, I prefer to do that separately. Do you agree?

--
With Best Regards,
Andy Shevchenko