Re: [PATCH] clk: si570: Simplify probe()

From: Stephen Boyd
Date: Mon Oct 23 2023 - 22:39:00 EST


Quoting Biju Das (2023-09-09 09:47:38)
> The driver has an OF match table, still, it uses an ID lookup table for
> retrieving match data. Currently, the driver is working on the
> assumption that an I2C device registered via OF will always match a
> legacy I2C device ID. The correct approach is to have an OF device ID
> table using i2c_get_match_data() if the devices are registered via OF/ID.
>
> Unify the OF/ID table by adding struct clk_si570_info as match data
> instead of clk_si570_variant and replace the ID lookup table for
> the match data by i2c_get_match_data(). This allows to simplify
> probe().
>
> Drop enum clk_si570_variant as there is no user.
>
> While at it, remove the trailing comma in the terminator entry for the OF
> table making code robust against (theoretical) misrebases or other similar
> things where the new entry goes _after_ the termination without the
> compiler noticing.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---

Applied to clk-next