Re: [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function

From: Maso Huang (黃加竹)
Date: Mon Oct 23 2023 - 22:29:11 EST


On Mon, 2023-10-23 at 13:07 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/10/23 11:54, Maso Huang ha scritto:
> > Remove redundant remove function of mt7986-wm8960.
> >
> > Signed-off-by: Maso Huang <maso.huang@xxxxxxxxxxxx>
>
> You're doing more than what you're advertising; you are:
>
> 1. Dropping the remove callback; and
> 2. Removing the mt7986_wm8960_priv structure
>
> You can do that in one single commit if you really want to, but you
> have to
> use the appropriate commit title and description, saying exactly what
> you're doing.
>
> Regards,
> Angelo
>

Hi Angelo,

Thanks for your review!
I'll devide into two with appropriate title and description in v2.

Best regards,
Maso