Re: [PATCH] KEYS: Clean up errors in key.h

From: Jarkko Sakkinen
Date: Mon Oct 23 2023 - 15:59:42 EST


On Thu Oct 12, 2023 at 12:06 PM EEST, wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: GuoHua Cheng <chenguohua@xxxxxxx>

So what was the patch?

> ---
> include/linux/key.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 938d7ecfb495..48a43c9efaed 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -503,18 +503,18 @@ extern void key_init(void);
> #define key_validate(k) 0
> #define key_serial(k) 0
> #define key_get(k) ({ NULL; })
> -#define key_revoke(k) do { } while(0)
> -#define key_invalidate(k) do { } while(0)
> -#define key_put(k) do { } while(0)
> -#define key_ref_put(k) do { } while(0)
> +#define key_revoke(k) do { } while (0)
> +#define key_invalidate(k) do { } while (0)
> +#define key_put(k) do { } while (0)
> +#define key_ref_put(k) do { } while (0)
> #define make_key_ref(k, p) NULL
> #define key_ref_to_ptr(k) NULL
> #define is_key_possessed(k) 0
> -#define key_fsuid_changed(c) do { } while(0)
> -#define key_fsgid_changed(c) do { } while(0)
> -#define key_init() do { } while(0)
> -#define key_free_user_ns(ns) do { } while(0)
> -#define key_remove_domain(d) do { } while(0)
> +#define key_fsuid_changed(c) do { } while (0)
> +#define key_fsgid_changed(c) do { } while (0)
> +#define key_init() do { } while (0)
> +#define key_free_user_ns(ns) do { } while (0)
> +#define key_remove_domain(d) do { } while (0)
>
> #endif /* CONFIG_KEYS */
> #endif /* __KERNEL__ */

BR, Jarkko