Re: [PATCH v1 2/2] jffs2: make cleanmarker support option

From: Richard Weinberger
Date: Mon Oct 23 2023 - 13:44:56 EST


----- Ursprüngliche Mail -----
> Von: "Martin Kurbanov" <mmkurbanov@xxxxxxxxxxxxxxxxx>
> If you disable the cleanmarker, the found clean block (filled with 0xff)
> will be erased again (see fs/jffs2/scan.c#L162).
> In my opinion, it is better to perform the block erasure again than to
> not work with such a nand flash at all.

Doesn't this case many re-erases at each mount time?

BTW: I tried your patch in nandsim, jffs2 was unhappy.
[ 56.147361] jffs2: notice: (440) jffs2_build_xattr_subsystem: complete building xattr subsystem, 0 of xdatum (0 unchecked, 0 orphan) and 0 of xref (0 dead, 0 orphan) found.
[ 56.200438] nand: nand_do_write_ops: attempt to write non page aligned data
[ 56.201090] jffs2: Write clean marker to block at 0x001f8000 failed: -22

Do you have an idea?

Thanks,
//richard