Re: [PATCH net-next v5 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports

From: Rob Herring
Date: Mon Oct 23 2023 - 13:43:46 EST


On Mon, Oct 23, 2023 at 09:51:00AM +0200, Linus Walleij wrote:
> On Mon, Oct 23, 2023 at 9:19 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> > Bindings using dsa.yaml#/$defs/ethernet-ports specify that
> > a DSA switch node need to have a ports or ethernet-ports
> > subnode, and that is actually required, so add requirements
> > using oneOf.
> >
> > Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> (...)
> > + oneOf:
> > + - required:
> > + - ports
> > + - required:
> > + - ethernet-ports
>
> Ooops I meant to drop the patch altogether because I just
> couldn't figure out how to test this.

Just move it up a level (no indent).

Rob