Re: [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction of new typedefs

From: Dan Carpenter
Date: Mon Oct 23 2023 - 10:43:25 EST


On Sat, Oct 21, 2023 at 12:12:31PM +0200, Jonathan Bergh wrote:
> This patch series fixes (removes) the introduction of several new typedefs
> for enums and structs in the octeon driver. First the declarations are
> fixed and then implementations are updated to remove references to the
> old typedefs.
>
> Changelog:
> * v1 -> v2: Fix breaking change spread across multiple patches
> * v2 -> v3: Break changes up into individual patches for each removed
> typedef
>
> Jonathan Bergh (7):
> staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t
> in octeon
> staging: octeon: Fix up introduction of new typedef
> cvmx_helper_interface_mode_t in octeon
> staging: octeon: Fix introduction of following new typedef
> cvmx_pow_wait_t in octeon
> staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t in
> octeon
> staging: octeon: Fix introduction of new typedef cvmx_pko_status_t in
> octeon
> staging: octeon: Fix introduction of new typedef
> cvmx_pip_port_status_t in octeon
> staging: octeon: Fix introduction of new typedef
> cvmx_pko_port_status_t in octeon driver
>
> drivers/staging/octeon/ethernet.c | 6 ++--
> drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------

Please don't change the stubs without change the arch/ code.

regards,
dan carpenter