Re: [PATCH v8 00/13] KVM: arm64: PMU: Allow userspace to limit the number of PMCs on vCPU

From: Marc Zyngier
Date: Mon Oct 23 2023 - 09:09:20 EST


On Fri, 20 Oct 2023 22:40:40 +0100,
Raghavendra Rao Ananta <rananta@xxxxxxxxxx> wrote:
>
> Hello,
>
> The goal of this series is to allow userspace to limit the number
> of PMU event counters on the vCPU. We need this to support migration
> across systems that implement different numbers of counters.

[...]

I've gone through the initial patches, and stopped before the tests
(which I usually can't be bothered to review anyway).

The comments I have a relatively minor and could be applied as fixes
on top if Oliver can be convinced to do so. Note that patch #4 has an
attribution issue.

> base-commit: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3

maz@valley-girl:~/hot-poop/arm-platforms$ git describe 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3
fatal: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 is neither a commit nor blob

Can you please make an effort to base your postings on a known, stable
commit? A tagged -rc would be best. but certainly not a random commit.

This sort of information is just as useful as "No functional change
intended"...

M.

--
Without deviation from the norm, progress is not possible.